fix: prevent invalid input in builder mode numeric fields#10
Merged
Conversation
- Add real-time input filtering for numeric fields: * Plateau width/height - digits only * Rover start X/Y coordinates - digits only * Filters out minus signs on real devices and letters/symbols on emulators - Enhance validation logic with clearer error messages: * "Must be a valid number" for invalid format * "Must be a positive number" for zero values * "Must be a non-negative number" for negative values - Add comprehensive test coverage: * Input filtering behavior tests * Updated validation tests for filtered inputs * Edge case handling (empty after filtering) - UX improvements: * Consistent behavior across real devices and emulators * Proactive prevention vs reactive error handling * Immediate visual feedback during typing * Eliminates user frustration from invalid input - Fixes builder mode input validation issue #9 - All tests passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves input validation issues in Builder mode where users could input invalid characters in numeric fields. On real devices, users could type minus signs despite coordinates being non-negative. On emulators, users could type any characters including letters and symbols. Implements real-time input filtering and enhanced validation logic.
Issues Fixed
Changes Made
Input Filtering (Prevention)
Enhanced Validation (Detection)
Comprehensive Testing
User Experience Improvements
Before Fix
After Fix
Testing
Manual Testing
Impact