Repository navigation
Qa/rate limit e2e and degraded agent notice - #2
Merged
Merged
Conversation
All three snippets told the developer to paste http://localhost:8787 into "Connect an agent". Every form of that is refused: plain http fails the HTTPS check, and localhost / 127.0.0.1 / LAN addresses fail the private-range check. No tunnel was mentioned anywhere in the repo, so the documented path to the Agent API — the product's most important public surface — dead-ended with no next step. TTHW for an agent developer was not slow, it was unreachable. The SSRF guard is right and stays exactly as it is. What was missing is the remedy, in the three places someone hits the wall: the snippets, the README, and the error messages themselves (both the client-side check that fires first and the server-side rejections behind it). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
.github/ held a workflow and two logos; there was no CONTRIBUTING, no CHANGELOG, no security policy, and no way to report a vulnerability in a product whose threat model is "assume agent output is hostile". - CONTRIBUTING.md: setup, the checks CI runs, and the two things that will bite you on the e2e suite (it needs a dev build for the window hook, and RATE_LIMIT_BOARDS_CREATE or 8 of 18 specs fail on 429). - SECURITY.md: private reporting, what is in scope, and the known tradeoffs (DNS rebinding window, fail-open limits, single-instance ws) so reporters are not rediscovering documented decisions. - CHANGELOG.md, including a protocol compatibility policy that makes the "/v1/ never changes incompatibly" promise explicit rather than a comment. - packages/agent-protocol/README.md: the loop, signature verification, idempotency and degraded semantics, and the fact that operations are staged as Proposals rather than applied. - Issue templates, including one for agent integration problems, and a PR template that surfaces the CLAUDE.md "ask first" items. Also corrects the README test count, which read 395 against an actual 466. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.