Skip to content

deps: bump golang.org/x/term from 0.40.0 to 0.41.0 in /src #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

deps: bump golang.org/x/term from 0.40.0 to 0.41.0 in /src #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/muxi-ai/cli

go 1.24.2
go 1.25.0
Copy link
Copy Markdown

@greptile-apps greptile-apps bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Go version directive breaks all CI pipelines

The go directive was bumped from 1.24.2 to 1.25.0 as a transitive consequence of golang.org/x/term v0.41.0 (its upstream go.mod now requires Go 1.25.0). However, all three CI workflows pin the Go toolchain to '1.24':

  • .github/workflows/ci.yml (line 25): go-version: '1.24'
  • .github/workflows/rc.yml (line 46): go-version: '1.24'
  • .github/workflows/release.yml (line 110): go-version: '1.24'

Starting with Go 1.21, the go directive in go.mod is enforced as a minimum toolchain requirement. A Go 1.24.x toolchain building a module that declares go 1.25.0 will refuse to proceed with an error such as:

go: module requires Go >= 1.25.0

Merging this PR as-is will cause every CI job (tests, RC builds, and release builds) to fail. The CI workflows need to be updated to go-version: '1.25' (or '1.25.0') before or alongside this dependency bump.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/go.mod
Line: 3

Comment:
**Go version directive breaks all CI pipelines**

The `go` directive was bumped from `1.24.2` to `1.25.0` as a transitive consequence of `golang.org/x/term v0.41.0` (its upstream `go.mod` now requires Go 1.25.0). However, all three CI workflows pin the Go toolchain to `'1.24'`:

- `.github/workflows/ci.yml` (line 25): `go-version: '1.24'`
- `.github/workflows/rc.yml` (line 46): `go-version: '1.24'`
- `.github/workflows/release.yml` (line 110): `go-version: '1.24'`

Starting with Go 1.21, the `go` directive in `go.mod` is enforced as a **minimum toolchain requirement**. A Go 1.24.x toolchain building a module that declares `go 1.25.0` will refuse to proceed with an error such as:

```
go: module requires Go >= 1.25.0
```

Merging this PR as-is will cause every CI job (tests, RC builds, and release builds) to fail. The CI workflows need to be updated to `go-version: '1.25'` (or `'1.25.0'`) before or alongside this dependency bump.

How can I resolve this? If you propose a fix, please make it concise.


require (
github.com/alecthomas/chroma/v2 v2.23.1
Expand All @@ -13,7 +13,7 @@ require (
github.com/fernet/fernet-go v0.0.0-20240119011108-303da6aec611
github.com/spf13/cobra v1.10.2
github.com/tidwall/gjson v1.18.0
golang.org/x/term v0.40.0
golang.org/x/term v0.41.0
gopkg.in/yaml.v3 v3.0.1
)

Expand Down Expand Up @@ -51,6 +51,6 @@ require (
github.com/yuin/goldmark v1.7.13 // indirect
github.com/yuin/goldmark-emoji v1.0.6 // indirect
golang.org/x/net v0.48.0 // indirect
golang.org/x/sys v0.41.0 // indirect
golang.org/x/sys v0.42.0 // indirect
golang.org/x/text v0.32.0 // indirect
)
8 changes: 4 additions & 4 deletions src/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,10 @@ golang.org/x/sys v0.0.0-20210809222454-d867a43fc93e/go.mod h1:oPkhp1MJrh7nUepCBc
golang.org/x/sys v0.0.0-20220310020820-b874c991c1a5/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.41.0 h1:Ivj+2Cp/ylzLiEU89QhWblYnOE9zerudt9Ftecq2C6k=
golang.org/x/sys v0.41.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
golang.org/x/term v0.40.0 h1:36e4zGLqU4yhjlmxEaagx2KuYbJq3EwY8K943ZsHcvg=
golang.org/x/term v0.40.0/go.mod h1:w2P8uVp06p2iyKKuvXIm7N/y0UCRt3UfJTfZ7oOpglM=
golang.org/x/sys v0.42.0 h1:omrd2nAlyT5ESRdCLYdm3+fMfNFE/+Rf4bDIQImRJeo=
golang.org/x/sys v0.42.0/go.mod h1:4GL1E5IUh+htKOUEOaiffhrAeqysfVGipDYzABqnCmw=
golang.org/x/term v0.41.0 h1:QCgPso/Q3RTJx2Th4bDLqML4W6iJiaXFq2/ftQF13YU=
golang.org/x/term v0.41.0/go.mod h1:3pfBgksrReYfZ5lvYM0kSO0LIkAl4Yl2bXOkKP7Ec2A=
golang.org/x/text v0.32.0 h1:ZD01bjUt1FQ9WJ0ClOL5vxgxOI/sVCNgX1YtKwcY0mU=
golang.org/x/text v0.32.0/go.mod h1:o/rUWzghvpD5TXrTIBuJU77MTaN0ljMWE47kxGJQ7jY=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
Expand Down
Loading