Repository navigation
fix(orchestrator): keep task executor through revision loop; harden judge wiring - #142
Merged
Merged
Conversation
…udge wiring - DeliveryProgress::Delivered now carries the task's executor kind; Reviser::revise receives it, so ExecutorReviser re-dispatches with the original kind instead of hardcoding ExecutorKind::ClaudeCode (unknown kinds still fall back to Claude) - HttpJudge gets 30s/10s request/connect timeouts, matching LlmClient/JevJudge, so a hung SHEPHERD_JUDGE_URL cannot stall the verification gate forever - build_judge() logs a warning when it falls back to AcceptAllJudge so an unconfigured production gate is visible instead of silently passing everything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeliveryProgress::Deliverednow carries the task's executor kind andReviser::revisereceives it, soExecutorReviserre-dispatches with the original kind instead of hardcodingClaudeCode(unknown kinds still fall back to Claude).LlmClient/JevJudge, so a hungSHEPHERD_JUDGE_URLcannot stall the verification gate forever.build_judge()logs a warning when no judge is configured instead of silently passing every deliverable.Verification
cargo test -p orchestrator(10/10)cargo check -p servercargo fmt --check+cargo clippy --workspace -D warnings