Conversation
The circle changes size as it moves from dead-center and opacity, as it moves away from either axis. Also, now it always stays withing the compass circle.
Rebased part of 269db3c.
|
It looks like this PR has several features which aren't related. I think it makes sense to show satellite locations for any being tracked, even without fix, but I don't see how that's related to leveling. |
|
Please consider making the leveling circle a preference (and default to off). I use satstat to see information about GPS fix quality, to force GPS on to preload ephemeris, and to visualize location providers. For all of this I hold my phone so I can read it, not trying to make it level. Perhaps if the level only comes on when the device is close, that would avoid the issue. |
|
Counterargument - it's a feature that doesn't clutter the satellite view too much, and may be helpful on some occasions. Satstat can even show maps, so visualising the orientation is IMO not really that big addition... But sure, if it's even default off, I don't really care in the end. I just don't want to maintain a parallel fork of satstat, unless there's a big uprising against this :-) |
|
@andree182 are you planning to switch to using the accelerometer, as announced in #76? Should I hold the pull request back until then? |
3 participants
Improved size, color and positioning of the levelling circle.