Repository navigation
Disk images: a folder comes out at once only with a 7-Zip known to make no links; any other copies file by file - #257
Merged
Merged
Conversation
…ke no links; any other copies file by file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From an automated security review of #256: the folder-at-once extraction was taken unless the banner said p7zip, so a detection failure (timeout, odd banner, an older 7-Zip without p7zip in its banner) fell to the bulk
7z xpath, where an old 7-Zip may create links from the image.x -snl-only when the banner positively names 7-Zip 21 or later and no p7zip; anything else copies file by file (links never made). Fail closed.