Add configurable browser tab title (#1055) - #1077
Open
dillan wants to merge 2 commits into
Open
Conversation
Adds resolveBrowserTabTitle() plus its spec. The stub returns the raw value, so the tests fail on purpose: a blank/whitespace value should fall back to "KIP" and a set value should be trimmed.
resolveBrowserTabTitle() now trims the value and falls back to "KIP" when blank. Adds a persisted browserTabTitle app setting (mirrors the instanceName pattern in SettingsService, defaulting to "KIP"), a "Browser Tab" field in Settings > Display, and an effect in AppComponent that keeps document.title in sync via Angular's Title service. Lets users running several KIP instances tell their tabs apart.
dillan
marked this pull request as ready for review
June 24, 2026 10:26
This was referenced Jun 30, 2026
Collaborator
|
The idea is to use same tab and multiple dashboards rather than multiple tabs. Browsers handle background tabs processing much differently with CPU, network throttling or even full sleep. Secondly KIP's primary designed goal is fullscreen, no browser UI and full touch so Tabs is not something I want to add focus on. Trying to keep code base focused. Maybe some day...whom knows. |
Contributor
Author
|
Sounds good. I appreciate the feedback. |
Contributor
|
@godind pardon me, but imho you are needlessly limiting how Kip can be used. To me the feature seems useful and the changes seem small and local, adding a minuscule bit of complexity to the codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1055
Problem
The browser tab title is hardcoded to
KIP, so users running several KIP instances (per boat / mast / engine) can't tell their tabs apart.Fix
Adds a persisted
browserTabTitleapp setting (mirrors the existinginstanceNamepattern inSettingsService, defaulting toKIP), a Browser Tab field in Settings → Display, and an effect inAppComponentthat keepsdocument.titlein sync via Angular'sTitleservice. A blank value falls back toKIP, and the resolver trims whitespace.Tests
resolveBrowserTabTitle()is a small pure helper unit-tested for the default/trim behavior (committed test-first, RED then GREEN). The settings accessors mirror the establishedinstanceNamepattern, and the whole feature (types + AOT templates) is verified by a production build.Notes
Existing stored configs without the field default to
KIPon load, so behavior is unchanged for current users.