Skip to content

RN Code Test #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mtavkhelidze wants to merge 24 commits into
base: master
Choose a base branch
from
Open

RN Code Test #12

mtavkhelidze wants to merge 24 commits into from

Conversation

@mtavkhelidze
Copy link

@mtavkhelidze mtavkhelidze commented Sep 6, 2021

  • Nothing can be serious if it's not in PowerPoint TypeScript
  • CSS/Animation might not be great: I'm not big
    on those, I just tried to make it maintainable
  • patch is there to fix "images aren't shown in iOS 14" React bug
  • Native modules should probably reject instead of returning an empty string
  • No error reporting in iOS module
  • Tab navigation should probably be inside Stack navigation
  • Loading indicators are missing

@mtavkhelidze
CT-0001 Convert project to TypeScript
ed513ed
@mtavkhelidze
CT-0002 Add component styles infrastructure
e884cba
@mtavkhelidze
CT-0003 Finish Product, add styling infrastructure
8b5e00e
@mtavkhelidze
CH-0004 Add Price, finish Product
3ad5e3f
@mtavkhelidze
CH-0005 Add Free label
86597de
@mtavkhelidze
CH-0006 Add scrollable categories
793097c
@mtavkhelidze
CT-0007 Fix styles
349e49f
@mtavkhelidze
CT-0008 Add animation, navigation
98e3125
@mtavkhelidze
CH-0009 Fix iOS 14 image display
44b5561
@mtavkhelidze
CT-0010 Add stack navigation, update product type
fa6112d
@mtavkhelidze
CT-0011 Add product details navigation infrastructure
ec66039
@mtavkhelidze
CH-0012 Fix market product display
95ca288
@mtavkhelidze
CH-0012 Set screen title
e145ab7
@mtavkhelidze
CH-0013 Add product details
2a46a4d
@mtavkhelidze
CH-0014 Remove avatar border
1bc9d78
@mtavkhelidze
CH-0013 Fix market styles
2ae366c
@mtavkhelidze
CH-0013 Add product details styles
2340227
@mtavkhelidze
CH-0015 Fix typings
7379226
@mtavkhelidze
CH-0016 Add Android code module
c4e127f
@mtavkhelidze
CT-0017 Add iOS module
95c6dce
@mtavkhelidze
CT-0018 Add Android module, code screen
a509c63
@mtavkhelidze
CT-0019 Fix animation
0826756
@mtavkhelidze
CT-0020 Refactor server.ts a bit
1f7eb98
@mtavkhelidze
CT-0021 Fix eslint errors, update some packages
b612183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mtavkhelidze