Accomodate for vcpkg#3
Open
julianxhokaxhiu wants to merge 1 commit into
Open
Conversation
Author
|
I found out there's an issue when linking the library. Let me fix that first. |
Author
|
Ready to go! The CI will complain until the other two PRs will not be merged first, once that is done feel free to re-run this PR CI job to test it if it builds correctly. |
julianxhokaxhiu
force-pushed
the
master
branch
4 times, most recently
from
cdee811 to
02ac378
Compare
- Rework the entire project to depend from other libraries from inside the project directory - Move source files into src - Move header files into include/openpsf - Ensure vcpkg integration for MSBuild on Azure Devops to resolve vcpkg manifests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will allow a more mature portability and inclusion against for eg. vcpkg by not cluttering the
includefolder with root level .h files. Instead, every project header file will be placed ininclude/openpsf.I personally tested the build on VS2019 after this patch ( and the dependencies patches ) and it seems to work fine.
Additionally the dependencies will now resolved within the project directory, instead of outside, allowing vcpkg to fully build this solution using either MSBuild way or CMake.
In order to fully test this PR, it is VERY IMPORTANT to follow the merge order stated below otherwise it will NOT work!
Order of merge: