Repository navigation
ci: remove manual CodeQL steps (default setup handles scanning) - #14
Merged
Merged
Conversation
mytrashcan
commented
Aug 2, 2026
mytrashcan
left a comment
Owner
Author
There was a problem hiding this comment.
Self-review (repo workflow — cannot APPROVE own PR).
Scope: removes the manual CodeQL init/analyze steps from ci.yml (9 deletions). CodeQL scanning is now exclusively handled by default setup (dynamic/github-code-scanning/codeql, active).
Why correct:
- Default setup was enabled 2026-08-02, which auto-disabled the CI workflow because it contained manual CodeQL steps (duplicate scanning). Removing them lets CI stay active.
- Removes the
build-mode: manualoverlay-base warning and thecodeql-action@v3deprecation (default setup is auto-maintained on v4). - Remaining
permissionsare correct:contents: read+security-events: write(dependency-review-action needs write).
Verification: YAML parses locally ✅; workflow re-enabled and shows active ✅; CodeQL default setup also active ✅.
No blocking findings.
Reviewed by Hermes Agent - deepseek-v4-flash
mytrashcan
commented
Aug 2, 2026
mytrashcan
left a comment
Owner
Author
There was a problem hiding this comment.
PR #14 Review — ci: remove manual CodeQL steps (default setup handles scanning)
Verified OK
- CodeQL default setup is configured for this repo (
state: configured, languages: actions/java-kotlin, weekly schedule) and is already producing analyses forrefs/pull/14/head— removing the manualinit/analyzesteps correctly eliminates the duplicate-scanning conflict that disabled the CI workflow, and drops thebuild-mode: manualoverlay-base error. - Removing
codeql-action@v3(SHA02c5e834...) clears the December 2026 deprecation warning; default setup maintains v4 automatically. - No other workflow files exist and no leftover CodeQL references remain after the change — nothing dangling. Job permissions (
contents: read,security-events: write) are unchanged.
Nit / Optional
- ci.yml:22 — after removing the CodeQL steps,
security-events: writeon theverifyjob may no longer be strictly needed: dependency-review-action posts PR comments (requirespull-requests: write, and degrades gracefully without it) and trivy uploads nothing. Keeping it is harmless (job-scoped token), but the PR description's claim that "dependency-review needs the write scope" slightly overstates the need —security-events: writeis the scope CodeQL uploads use, which default setup now owns.
Good Things
- Root cause was verified before changing config: the workflow-disable state came from duplicate scanning, and this removes the duplication at the source instead of blindly re-enabling the workflow.
- Minimal, focused diff (9 deletions) with a clear verification section.
Summary
No blocking or should-fix issues. The fix is correct — manual CodeQL v3 steps were redundant with default setup and caused the disabled-workflow state. Safe to merge.
Reviewed by Hermes Agent - deepseek-v4-flash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the "Actions workflow not enabled / manually set to inactive" state and CodeQL deprecation warnings.
Root cause: When CodeQL default setup was enabled, GitHub disabled the existing CI workflow because it contained manual CodeQL steps (init + analyze) — duplicate scanning. The manual steps also used
codeql-action@v3, which is deprecated (December 2026), andbuild-mode: manualconflicted with default setup.Fix: Removed the manual CodeQL
initandanalyzesteps fromci.yml. CodeQL scanning is now exclusively handled by default setup (automatically maintained, v4).Also addresses in the run log:
Cannot build an overlay-base database because build-mode is set to "manual"— gone (no manual init step)CodeQL Action v3 will be deprecated in December 2026— gone (default setup uses v4)Verification
contents: read+security-events: writescoped (dependency-review needs the write scope; trivy uploads nothing)