Repository navigation
feat(common): filter logs with LOG_LEVEL - #142
Merged
Merged
Conversation
Every service logged at info with no way to quiet it, which is noisy for large audiences. The shared logger now drops entries below LOG_LEVEL (info, warn, or error; default info). Unknown values keep everything, and browsers, which have no environment, log as before. Also moves createLogger's doc comment back onto it.
github-actions
Bot
added
documentation
Owner
Author
|
Self-review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The shared logger in
@openstreamgrid/common, used by the tracker, origin, sidecar writer, Node peer, and SDK, now honorsLOG_LEVEL:info(default) writes everything, as before.warndrops info entries.errorwrites errors only.Unknown values keep everything, so a typo cannot silence logs. Values are trimmed and case-insensitive. The variable is read through a
globalThis.processguard, so browsers, which have no environment, log as before.Also:
createLogger's doc comment back onto it (it had drifted above the segment-pattern constant).LOG_LEVELat the top of the README configuration section (EN/KO).Tests
A common test covers
warn,ERROR(trimmed and case-folded), an unknown value, and unset. common: 8 pass.