add speed attribute to PiperSpeaker#11
Open
Duve3 wants to merge 1 commit into
Open
Conversation
Owner
|
Hi @Duve3 Thank you for taking your time, I've been caught up for a few weeks, I'll review your PR as soon as I can, sorry for the delay. |
n1teshy
requested changes
May 16, 2026
| @@ -149,6 +153,9 @@ def __init__( | |||
|
|
|||
| self.volume = volume | |||
|
|
|||
Owner
There was a problem hiding this comment.
Please remove the blank line, that will make a block of properties (volume and speed)
| self.volume = volume | ||
|
|
||
| self.speed = speed | ||
| self.length_scale = str(1/self.speed) |
Owner
There was a problem hiding this comment.
please remove the self.speed = speed line and set length_scale directly
| file, | ||
| "-q", | ||
| "--length-scale", | ||
| self.length_scale # this "length_scale" is just the speed value inverted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to increase or decrease the speed of PiperSpeaker, along with the necessary documentation.
This commit also adds testing for 2x speed.