Skip to content

[TEST] Improve coverage and robustness for safeListSources and safeListTasks#480

Open
n24q02m wants to merge 2 commits into
mainfrom
jules-fix-safelistsources-tests-10275601429116819841
Open

[TEST] Improve coverage and robustness for safeListSources and safeListTasks#480
n24q02m wants to merge 2 commits into
mainfrom
jules-fix-safelistsources-tests-10275601429116819841

Conversation

@n24q02m

@n24q02m n24q02m commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Improved unit tests for safeListSources and safeListTasks in background.js.

  • Added verification that callBatchExecute is called with correct RPC IDs ('YqkSHd' for sources, 'p1Takd' for tasks) and payloads.
  • Used JSON.stringify for robust comparison of arrays returned from the node:vm sandbox to prevent realm mismatch issues.
  • Added a new test case for safeListSources to verify that it correctly filters out non-GitHub sources and repos with Suggestions disabled.
  • Isolated safeList wrapper testing by mocking internal functions (listTasks, listSuggestionEnabledSources) to verify error logging and recovery.

PR created automatically by Jules for task 10275601429116819841 started by @n24q02m

…tTasks

Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant