🎨 Palette: Use semantic fieldset/legend for form groups#482
Conversation
Replaced generic `<div class="setting-row">` elements with native `<fieldset>` and `<legend>` for radio button/button groups in `popup.html`. Removed duplicate/workaround ARIA attributes, ensuring cleaner markup and more robust accessibility for screen readers, while preserving visual presentation via `popup.css`. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
1 participant
💡 What
Replaced generic
<div class="setting-row">and<label id="...">combinations with native semantic HTML<fieldset>and<legend>elements for grouped form controls (Operation, Execution Mode, and Scope) inpopup.html.🎯 Why
Using native
<fieldset>and<legend>is the web standard for grouping related form controls. It provides automatic, robust context for assistive technologies (like screen readers) without relying on verbose and sometimes brittle ARIA attributes (role="radiogroup",role="group",aria-labelledby). This change simplifies the DOM, improves semantic correctness, and removes technical debt.📸 Before/After
Visually, the UI is identical. The visual styles of
<fieldset>have been reset to match the standard layout, and<legend>is styled precisely like the previous labels. See attached screenshots in verification steps for proof of unaltered visuals.♿ Accessibility
role="radiogroup",role="group",aria-labelledby.<fieldset>,<legend>) which natively establishes group boundaries and names for screen readers.PR created automatically by Jules for task 1391499113738085438 started by @n24q02m