🎨 Palette: Replace generic div with semantic fieldset for form groups#483
🎨 Palette: Replace generic div with semantic fieldset for form groups#483n24q02m wants to merge 2 commits into
Conversation
This commit replaces generic `<div class="setting-row">` containers with `<fieldset class="setting-row">` and grouped `<label>`s with `<legend>`s for the Operation, Execution Mode, and Scope selections in the extension popup UI. This change aligns with HTML semantics, making the form accessibility significantly better by providing implicit context to screen readers without needing to parse custom ARIA relationships. Existing popup.css was modified to appropriately reset and mirror the visual styles of generic containers and labels to these newly added tags. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This commit replaces generic `<div class="setting-row">` containers with `<fieldset class="setting-row">` and grouped `<label>`s with `<legend>`s for the Operation, Execution Mode, and Scope selections in the extension popup UI. This change aligns with HTML semantics, making the form accessibility significantly better by providing implicit context to screen readers without needing to parse custom ARIA relationships. Existing popup.css was modified to appropriately reset and mirror the visual styles of generic containers and labels to these newly added tags. Additionally, tests were updated to expect `<legend>` tags instead of the ARIA equivalent. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
1 participant
💡 What: Replaced generic
divs with nativefieldsets andlegends for grouped radio buttons and buttons inpopup.html.🎯 Why: Generic containers require complex ARIA setup (which were missing or slightly incomplete) to communicate relationship state to assistive technologies. Native semantic elements establish these relationships intrinsically, ensuring screen reader compatibility.
📸 Before/After: Visual presentation is identical; the changes are strictly under-the-hood HTML semantic upgrades.
♿ Accessibility: This enhances context and grouping logic for screen readers, allowing users to understand that inputs like 'Dry Run' and 'Run' belong to 'Execution Mode'.
PR created automatically by Jules for task 579775650357690644 started by @n24q02m