🎨 Palette: Use semantic fieldsets for form grouping#486
Conversation
Replaced generic `div` containers and pseudo-labels using `role="group"` and `role="radiogroup"` with native `<fieldset>` and `<legend>` elements. This inherently structures grouped form controls (like radio buttons or segmented buttons) for assistive technologies. We also added a CSS reset for browser default `fieldset` styles (`border`, `padding`, `margin`) and styled `<legend>` directly instead of managing `aria-labelledby` attributes. Updated unit tests accordingly. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
1 participant
💡 What:
Replaced
<div>elements possessing ARIA roles likerole="group"androle="radiogroup"and their accompanying pseudo-labels (viaaria-labelledby) with native semantic HTML elements (<fieldset>and<legend>). Reset their styling to maintain visual consistency.🎯 Why:
According to W3C guidelines, native HTML elements provide the correct semantic structure for grouped form controls out-of-the-box across screen readers and other assistive tech without needing additional ARIA glue.
📸 Before/After:
(No visual changes, purely structural/semantic change)
♿ Accessibility:
Provides a strictly compliant semantic grouping method for interactive controls like operation modes, execution modes, and scope selections, making them reliably discoverable and announced on screen readers.
PR created automatically by Jules for task 12880570605383531587 started by @n24q02m