🎨 Palette: Use semantic fieldsets for grouping form controls#490
🎨 Palette: Use semantic fieldsets for grouping form controls#490n24q02m wants to merge 1 commit into
Conversation
Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
💡 What: Replaced generic
<div>tags that used explicitrole="group"/role="radiogroup"andaria-labelledbyattributes with native semantic HTML<fieldset>and<legend>tags in the popup.🎯 Why: To improve the underlying markup and adhere to the W3C recommended standard for grouping related form controls (like radio buttons). This improves the experience for screen reader users natively.
📸 Before/After: Visuals are exactly the same, as the browser default styling for
<fieldset>was reset.♿ Accessibility: Uses the native semantic
<fieldset>and<legend>elements rather than explicit ARIA attributes, providing a more robust accessible experience out of the box.PR created automatically by Jules for task 8600619215105986868 started by @n24q02m