🛡️ Sentinel: [HIGH] Fix storage exhaustion vulnerability#497
Conversation
…torage Add a size check for `CACHE_START_CONFIG` payloads to prevent Denial of Service via `chrome.storage.session` quota exhaustion. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
…torage Add a size check for `CACHE_START_CONFIG` payloads to prevent Denial of Service via `chrome.storage.session` quota exhaustion. Also fix popup UI accessibility test regressions. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
1 participant
🚨 Severity: HIGH
💡 Vulnerability: The background script accepted config payloads from content scripts via
CACHE_START_CONFIGand stored them inchrome.storage.sessionwithout validating their size.🎯 Impact:
chrome.storage.sessionhas a strict quota (1MB). A maliciously large payload could exhaust this quota, crashing the service worker or preventing other critical extension state operations, leading to a Denial of Service (DoS).🔧 Fix: Added a payload size check in
background.jsto reject any config payload whose JSON representation exceeds 100,000 characters.✅ Verification: Added a security test case in
tests/security.test.jsto simulate a >100KB payload and verify it is rejected with the appropriate error. All tests pass successfully.PR created automatically by Jules for task 2815510412640451585 started by @n24q02m