🛡️ Sentinel: [CRITICAL/HIGH] Fix storage exhaustion DoS vulnerability#501
🛡️ Sentinel: [CRITICAL/HIGH] Fix storage exhaustion DoS vulnerability#501n24q02m wants to merge 2 commits into
Conversation
Added payload size validation to the `CACHE_START_CONFIG` message handler to prevent potential Denial of Service (DoS) caused by abnormally large payloads exhausting the `chrome.storage.session` quota. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Added payload size validation to the `CACHE_START_CONFIG` message handler to prevent potential Denial of Service (DoS) caused by abnormally large payloads exhausting the `chrome.storage.session` quota. Also fixed UI tests related to form input accessibility. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
1 participant
🚨 Severity: HIGH
💡 Vulnerability: The application was accepting arbitrarily large payloads from content scripts and storing them directly in
chrome.storage.sessionvia theCACHE_START_CONFIGmessage handler without any length validation.🎯 Impact:
chrome.storage.sessionhas a strict quota (typically 1MB). If a malicious or malfunctioning script sends overly large payloads, it could exhaust the extension's storage quota, causing a Denial of Service (DoS) and potentially breaking functionality.🔧 Fix: Added payload length validation. If
JSON.stringify(msg.config).lengthexceeds 100KB, the request is rejected with a security error.✅ Verification:
pnpm testsuccessfully executes the test suite, including a newly added test that explicitly tests this size limit behavior.PR created automatically by Jules for task 13332647845842631908 started by @n24q02m