🎨 Palette: [UX improvement] Semantic HTML for form control grouping#502
🎨 Palette: [UX improvement] Semantic HTML for form control grouping#502n24q02m wants to merge 1 commit into
Conversation
Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
💡 What:
Replaced generic
<div class="setting-row">containers that act as groups with native semantic<fieldset>tags. Converted their explicit heading<label>elements to<legend>tags, and removed redundant ARIA attributes (role="radiogroup",role="group",aria-labelledby) from the inner containers. Added CSS reset for<fieldset>to preserve layout and mapped<label>styling to<legend>.🎯 Why:
Using native semantic elements (
<fieldset>and<legend>) is a superior accessibility practice compared to relying on generic<div>tags paired withroleandaria-labelledbyattributes. It provides immediate, out-of-the-box structural meaning to screen readers and reduces markup complexity and maintenance surface area.📸 Before/After:
(Visually identical, structural change only. See verification screenshot in PR).
♿ Accessibility:
role="radiogroup"androle="group"with native<fieldset>.aria-labelledby) with native<legend>elements.PR created automatically by Jules for task 4897535285164563902 started by @n24q02m