Skip to content

🎨 Palette: [UX improvement] Semantic HTML for form control grouping#502

Open
n24q02m wants to merge 1 commit into
mainfrom
palette/semantic-html-grouping-4897535285164563902
Open

🎨 Palette: [UX improvement] Semantic HTML for form control grouping#502
n24q02m wants to merge 1 commit into
mainfrom
palette/semantic-html-grouping-4897535285164563902

Conversation

@n24q02m

@n24q02m n24q02m commented Jun 21, 2026

Copy link
Copy Markdown
Owner

💡 What:
Replaced generic <div class="setting-row"> containers that act as groups with native semantic <fieldset> tags. Converted their explicit heading <label> elements to <legend> tags, and removed redundant ARIA attributes (role="radiogroup", role="group", aria-labelledby) from the inner containers. Added CSS reset for <fieldset> to preserve layout and mapped <label> styling to <legend>.

🎯 Why:
Using native semantic elements (<fieldset> and <legend>) is a superior accessibility practice compared to relying on generic <div> tags paired with role and aria-labelledby attributes. It provides immediate, out-of-the-box structural meaning to screen readers and reduces markup complexity and maintenance surface area.

📸 Before/After:
(Visually identical, structural change only. See verification screenshot in PR).

♿ Accessibility:

  • Replaced synthetic role="radiogroup" and role="group" with native <fieldset>.
  • Replaced synthetic grouping labels (aria-labelledby) with native <legend> elements.
  • Cleaned up redundant ARIA attributes.
  • Ensured keyboard navigation and focus states remain unaffected by layout preservation.

PR created automatically by Jules for task 4897535285164563902 started by @n24q02m

Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant