🛡️ Sentinel: [MEDIUM] Add input length limits to API requests#40
🛡️ Sentinel: [MEDIUM] Add input length limits to API requests#40n24q02m wants to merge 1 commit into
Conversation
Adds `max_length` limits to Pydantic models in `src/tacet/serve/server.py` (`AskRequest`, `DistillRequest`, `GraphIngestRequest`) using `Field`. This prevents potential Denial of Service (DoS) attacks from unbounded payloads exhausting memory or CPU during JSON deserialization. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: The FastAPI Pydantic models lacked input length limits, making the endpoints vulnerable to Denial of Service (DoS) attacks via excessively large payloads (multi-megabyte strings or massive lists).
🎯 Impact: Attackers could cause high memory usage or CPU exhaustion, potentially crashing the server or impacting availability.
🔧 Fix: Added Pydantic
Fieldconstraints (max_length=256for query strings,max_length=100for short arrays, andmax_length=10000for batch ingest arrays).✅ Verification: Tested via
uv run pytestand verified byuv run ruff check ..PR created automatically by Jules for task 4032967130263267345 started by @n24q02m