Repository navigation
chore(workflows): rename local job to pr-check so check prefix matches branch protection - #61
Merged
Merged
Conversation
…s branch protection
Branch protection now requires "pr-check / ASCII-only check" and
"pr-check / Standards drift check" (set up to match the new
shared wrapper contract). The local job was still named "shared",
producing checks prefixed with "shared:" instead. Without this
rename, the PR can never satisfy the required status checks.
Also bypasses the pr-check.yml wrapper and calls
pr-validation.yml@v23 directly. The wrapper adds an extra job
layer ("pr-check:pr-validation:ascii-check") that made the check
name harder to read. With the direct call + the local job
renamed to "pr-check", the check name is the clean
"pr-check:ascii-check" / "pr-check:Standards drift check" the
branch protection expects.
Refs: n3ary/actions#35, n3ary/actions#36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Branch protection now requires the new
pr-check / ASCII-only checkandpr-check / Standards drift checkcontexts. The local job was still namedshared, producing checks prefixed withshared:instead. Without this rename, the PR can never satisfy the required status checks.Also bypasses the
pr-check.ymlwrapper and callspr-validation.yml@v23directly. The wrapper adds an extra job layer that makes the check name harder to read.Refs: n3ary/actions#35, n3ary/actions#36