feat: ✨ Integrate neverthrow for error handling and enhance GhinClient methods#33
Merged
Conversation
- Added .DS_Store and .data/ to .gitignore for better file management. - Modified validation message in schemaCourseSearchRequest for clarity. - Enhanced schemaCourseDetailsRequest to include default value for include_altered_tees.
…ache client - Introduced Vitest as the testing framework with configuration for coverage reporting. - Created unit tests for GhinClient, validating its methods and constructor behavior. - Added tests for InMemoryCacheClient to ensure correct value storage and retrieval. - Implemented validation tests for cache client and client config schemas. - Established validation tests for various data types including string, number, boolean, and handicap.
- Added "type": "module" to package.json for ES module support. - Configured Vitest to target Node 18 in vitest.config.ts. - Updated RequestClient tests to include cache in the configuration and added type annotations for ZodSchema.
…t methods - Added the `neverthrow` library to manage error handling in GhinClient methods. - Refactored methods to return `Result` types, improving error management and clarity. - Updated error handling in various methods to throw specific errors for better debugging. - Enhanced test coverage for error handling scenarios in RequestClient and GhinClient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.