Repository navigation
Conversation
The image listens on 8080 and ships wget but not curl, so the compose healthcheck always failed and the docker run examples mapped the wrong port. Fix both, along with the LND certificate instructions, and note that the reverse proxy must terminate TLS since callback URLs are always https. Document the release binaries, the HTTP endpoints, and how to build and run the tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add a HEALTHCHECK that polls /health with busybox wget, so deployments no longer need their own, and drop it from the example compose file. Ship an appsettings.json that logs Microsoft.AspNetCore at Warning, so the healthcheck doesn't log six lines every 30 seconds. Document that cln-grpc client certificates grant full control of the node and how to limit their exposure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nGoline
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the deployment problems found running v0.1.0 against Core Lightning, plus README drift.
Image
HEALTHCHECK: polls/healthwith busyboxwget(the alpine image has nocurl) on${ASPNETCORE_HTTP_PORTS:-8080}. Deployments no longer need their own healthcheck; the example compose file drops its copy.appsettings.jsonthat logsMicrosoft.AspNetCoreatWarning. The healthcheck used to log about 6 Information lines every 30 s; now it logs none. Startup lines (Microsoft.Hosting.Lifetime) are kept. SetLogging__LogLevel__Microsoft.AspNetCore=Informationto see requests again..dockerignorenow allows that one file.docker-compose.yml
ASPNETCORE_URLS=http://+:80is dropped and the mapping becomes65535:8080.example.nginxstill points at 65535.curlhealthcheck is removed; the image's healthcheck is used instead.README
docker runexamples used-p 80:80→-p 8080:8080./.well-known/lnurlp/and/lnurl/, and treatCLN__*like hot-wallet keys./.lnd/tls.certpath was wrong; raw PEM isn't accepted), TLS requirement for the proxy, release binaries, endpoint table, development and test commands,docker compose.Verified
End to end against a CLN v26.06.9 regtest node, with this branch combined with #13 and #16 and the deployment's layout (container-to-container gRPC, only 8080 published):
healthy./healthlog lines over 10 s; startup lines still shown.description_hash == sha256(metadata)perlightning-cli decode, comment in the label, real payment settles, and verify returns the preimage.Merges cleanly with #13, #14 and #16.
🤖 Generated with Claude Code