Skip to content

fix: improve reconnect recovery with async lock fix and immediate redo trigger #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cxhello wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: improve reconnect recovery with async lock fix and immediate redo trigger #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76e193a
fix(transport): use async with for asyncio.Lock in ConnectResetReques…
cxhello May 21, 2026
af397e9
fix(redo): trigger redo immediately on reconnect instead of waiting u…
cxhello May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions v2/nacos/redo/abstract_redo_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def __init__(self, module:str):

async def on_connected(self) -> None:
self._connected = True
await self.start_redo_task()

async def on_disconnect(self) -> None:
self._connected = False
Expand Down
2 changes: 1 addition & 1 deletion v2/nacos/transport/rpc_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ async def request_reply(self, request: Request) -> Optional[ConnectResetResponse
return None

try:
with self.rpc_client.lock:
async with self.rpc_client.lock:
if self.rpc_client.is_running():
if request.server_ip.strip():
server_info = ServerInfo(request.server_ip, int(request.server_port))
Expand Down
Loading