Derive the C++ app version from the Python package's __version__ - #12
Merged
Merged
Conversation
src/Version.h hard-coded 0.0.6 while releases are tagged from naja_schematic.__version__ (0.1.1), so the About dialog of the wheel's bundled viewer showed a stale version. CMake now reads __version__ and passes it to both app targets as NAJA_SCHEMATIC_VERSION_STRING, making __init__.py the single version for the project. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
xtofalex
added a commit
that referenced
this pull request
Sep 29, 2026
Derive the C++ app version from the Python package's __version__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/Version.h hard-coded 0.0.6 while releases are tagged from naja_schematic.version (0.1.1), so the About dialog of the wheel's bundled viewer showed a stale version. CMake now reads version and passes it to both app targets as NAJA_SCHEMATIC_VERSION_STRING, making init.py the single version for the project.