Colab test notebook - #15
Merged
Merged
Conversation
Escaped Verilog instance names can contain '/', so a path joined with '/' and split back names the wrong instances. The C++ viewer now keys every instance by an InstancePath (std::vector<std::string>): selection, diagnoses, the tree, the layout and all schematic maps. Composite keys (bus groups, endpoints, pending pin requests, wire ends) are tuples. displayPath() joins names for display only. On the wire, expand_instance_terms/load_instance_internals now carry the box's path as an `instance_path` list (echoed in the reply) instead of a `path_key` string; both providers echo it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- naja_schematic.show(instance=None, *, height=600, diagnosis=None), so show(inst) / show(["u1", "u2"]) work; height and diagnosis are keyword-only. - show_instance() takes a najaeda Instance, a list of names, or a single name; strings are never split on "/" (escaped names can contain it). - Colab notebook: lists for paths, and no diagnosis cells for now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.