Fix off-by-one error finding 3' cutoff.#51
Open
MikkelSchubert wants to merge 1 commit intonajoshi:masterfrom
Open
Fix off-by-one error finding 3' cutoff.#51MikkelSchubert wants to merge 1 commit intonajoshi:masterfrom
MikkelSchubert wants to merge 1 commit intonajoshi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes an off-by-one error in the 'sliding_window' function. Briefly, the function checks if window_start + window_size > fqrec->qual.l, to determine if the current window is the last window, and if it should therefore refine the 3' cutoff. However, the loop is constrained to i + window_size <= fqrec->qual.l, where i == window_start, so that check never succeeds. The result is that trailing low quality bases are not correctly trimmed if the average quality does not fall below the minimum before the last window.
The problem can be demonstrated with the following FASTQ read:
This is the output when processed with the current head (d802a80):
With the attached patch, the final refinement is carried out at the last window: