fix(notify): cmux-compatible agent notifications without alerter - #40
Open
nakulbh wants to merge 1 commit into
Open
fix(notify): cmux-compatible agent notifications without alerter#40nakulbh wants to merge 1 commit into
nakulbh wants to merge 1 commit into
Conversation
OpenCode's notify plugin shells out to `cmux notify` when CMUX_* env vars are set. Without that path it falls back to the external alerter binary and surfaces a toast on macOS. - Inject RMUX_* and CMUX_* into every PTY - Add rmux-cli __cmux-compat (and argv0 `cmux`) for notify/set-status/clear-status - Install ~/.local/bin/cmux shim on first terminal spawn - Install rmux-cli + cmux symlink from install.sh - Route notification.create workspace/pane ids into the store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenCode's notify plugin (kdco-notify) prefers
cmux notifywhenCMUX_*env vars are set andcmuxis onPATH. Without that path it falls back to the externalalerterbinary on macOS, which produced:This PR makes rmux a drop-in cmux notify target so agent completion notifications go through rmux's socket API / desktop notifier instead of alerter.
RMUX_*andCMUX_*into every PTYrmux-cli __cmux-compatfornotify/set-status/clear-statuscmuxis handled the same way~/.local/bin/cmuxshim on first terminal spawnrmux-cli+cmuxsymlink frominstall.shnotification.createworkspace/pane ids into the storeTest plan
cargo test -p rmux-cli --libcargo clippy -p rmux-cli -p rmux-app -p rmux-api -p rmux-terminal --all-targets -- -D warningsecho $CMUX_WORKSPACE_ID/$CMUX_SOCKET_PATHare set~/.local/bin/cmuxexists andwhich cmuxfinds itcmux notify --title "test" --body "hello"creates an in-app notification (no alerter)