base-image upload: add --from-file flag for local tar images#1855
Open
avdv wants to merge 2 commits into
Open
Conversation
Add a --from-file flag to `nsc base-image upload` that loads the source image from a local tar file (docker/podman save format) instead of pulling from a remote registry. This is useful for images built locally with Podman or Nix that are not pushed to any registry: podman save localhost/worker-image:latest -o worker-image.tar nsc base-image upload --from-file worker-image.tar worker-image:latest When --from-file is used, only the target tag argument is required (the source-image argument is omitted). Without --from-file, the original two-argument form is unchanged.
avdv
commented
Jul 3, 2026
| return err | ||
| } | ||
| default: | ||
| return fmt.Errorf("unsupported image type: %s", desc.MediaType) |
Author
There was a problem hiding this comment.
Note, this switch statement was removed because it only worked for the Image case anyway (since makeAnnotations(ctx, desc, *annotateWithDigest) in the original code already called desc.Image() unconditionally which I think would return an error for indexes).
Author
There was a problem hiding this comment.
Disregard this, I looked a bit deeper and AFAIU this was working properly before. Adjusted to make it work again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a --from-file flag to
nsc base-image uploadthat loads the source image from a local tar file (docker/podman save format) instead of pulling from a remote registry.This is useful for images built locally with Podman or Nix that are not pushed to any registry:
podman save localhost/worker-image:latest -o worker-image.tar
nsc base-image upload --from-file worker-image.tar worker-image:latest
When --from-file is used, only the target tag argument is required (the source-image argument is omitted). Without --from-file, the original two-argument form is unchanged.