368436 évolution des PortTypes by moxyom · Pull Request #783 · nanego/my-dcim

moxyom · 2026-07-28T14:36:41Z

No description provided.

nicolas-brousse · 2026-07-31T09:04:00Z

+  scope :attachable_to_server, -> { where("? = ANY(attachable_to)", :server) }
+  scope :attachable_to_pdu, -> { where("? = ANY(attachable_to)", :pdu) }


Suggested change

scope :attachable_to_server, -> { where("? = ANY(attachable_to)", :server) }

scope :attachable_to_pdu, -> { where("? = ANY(attachable_to)", :pdu) }

scope :usable_by, -> (usable_by) { where("? = ANY(attachable_to)", usable_by) }

nicolas-brousse · 2026-07-31T09:13:25Z

  has_many :card_types, dependent: :restrict_with_error
  has_many :sockets, class_name: "PowerDistributionUnit::Socket", dependent: :restrict_with_error

+  validates :attachable_to, array_inclusion: { in: %w[pdu server] }


Enum definition is missing, no?

I have not found a "multiple value enum" built in for rails. It is juste an array of string isn't it ?

nicolas-brousse · 2026-07-31T09:17:01Z

+  def change
+    rename_column :port_types, :power, :is_power
+
+    create_enum :port_attachable_type, %w[pdu server]


Suggested change

create_enum :port_attachable_type, %w[pdu server]

create_enum :port_types_usable_by, %w[pdu server]

nicolas-brousse · 2026-07-31T09:17:13Z

+    up_only do
+      PortTypeMigration.reset_column_information
+      PortTypeMigration.find_each do |port_type|
+        port_type.update!(is_power: port_type.name == "ALIM", attachable_to: ["server"])


Suggested change

port_type.update!(is_power: port_type.name == "ALIM", attachable_to: ["server"])

port_type.update!(is_power: port_type.name == "ALIM", usable_by: ["server"])

nicolas-brousse · 2026-07-31T09:17:49Z

+    rename_column :port_types, :power, :is_power
+
+    create_enum :port_attachable_type, %w[pdu server]
+    add_column :port_types, :attachable_to, :enum, enum_type: :port_attachable_type, array: true


Suggested change

add_column :port_types, :attachable_to, :enum, enum_type: :port_attachable_type, array: true

add_column :port_types, :usable_by, :enum, enum_type: :port_types_usable_by, array: true

nicolas-brousse · 2026-08-05T14:07:11Z


+  def self.usable_by_options_for_select
+    PortType::USABLE_BY_VALUES.map do |value|
+      [I18n.t(".activerecord.attributes.port_type.usable_by/#{value}"), value]


Does human_attribute_name usable here?

nicolas-brousse · 2026-08-05T14:22:49Z

              blank: can't be blank, or "All domains" must be checked

+      messages:
+        array_inclusion: "includes unauthorized values : %{wrong_values}"


Suggested change

array_inclusion: "includes unauthorized values : %{wrong_values}"

array_inclusion: "includes unauthorized values: %{wrong_values}"

nicolas-brousse · 2026-08-05T14:40:08Z

    <% end %>

+    <% table.with_column(PortType.human_attribute_name(:usable_by)) do |port_type| %>
+      <%= port_type.usable_by.to_sentence %>


Values not translated. Maybe use decorator for this.

nicolas-brousse · 2026-08-05T14:40:16Z

+
+        <dl class="show-page_dl d-grid row-gap-2 mb-0">
+          <dt class="pb-2"><%= PortType.human_attribute_name(:usable_by) %></dt>
+            <dd class="mb-0 pb-2 ps-3"><%= @port_type.usable_by.to_sentence %></dd>


Values not translated. Maybe use decorator for this

nicolas-brousse · 2026-08-05T14:50:58Z

+        usable_by/server: Server
+        usable_by/pdu: Pdu


Use same format as we usually do for enums

nicolas-brousse · 2026-08-05T14:51:04Z

+        usable_by/server: Serveur
+        usable_by/pdu: Pdu


Use same format as we usually do for enums

nicolas-brousse · 2026-08-05T14:51:27Z

        one: Network hub cluster
        other: Network hub clusters
      color: Color
+      port_type:


Add missing attributes already present in fr

nicolas-brousse · 2026-08-05T15:00:06Z

-    def port_type_options_for_select
-      PortTypeDecorator.options_for_select(PortType.where(power: true))
+    def port_types_options_for_select
+      PortTypeDecorator.options_for_select(PortType.usable_by(:pdu))


should only show usable_by(:pdu) & power: true for this form.

nicolas-brousse · 2026-08-06T21:50:03Z

+          # get sql type to cast properly
+          # It returns the array's element type
+          element_type = columns_hash[name.to_s].sql_type
+
+          # encode array so it can be understood by PG
+          encoder = PG::TextEncoder::Array.new
+          encoded = encoder.encode(db_values)
+
+          where(
+            "#{name} @> ?::#{element_type}[]",
+            encoded,
+          )


Does where("#{name} @> ARRAY[?]::varchar[]", db_values) works?

It does not if I'm right.
Like the DB fields is / (can be) a PG enum, @> will not accept another type as the exact field type.
A PG enum value isn't comparable to a varchar, the array elements can also be integers ...

The values are sent as text, and PG cast them. I haven't found any encoder for that column API

moxyom force-pushed the 368436-port-type-evolution branch from f832eb1 to ae33114 Compare July 29, 2026 13:57

moxyom marked this pull request as ready for review July 29, 2026 14:59

nicolas-brousse requested changes Jul 31, 2026

View reviewed changes

nicolas-brousse assigned moxyom Aug 4, 2026

moxyom force-pushed the 368436-port-type-evolution branch from 0c7935a to dd80681 Compare August 4, 2026 09:10

nicolas-brousse force-pushed the 368436-port-type-evolution branch from 4bc769a to 1582efd Compare August 5, 2026 14:38

nicolas-brousse requested changes Aug 5, 2026

View reviewed changes

Comment thread app/models/concerns/enum/array.rb

nicolas-brousse reviewed Aug 6, 2026

View reviewed changes

moxyom added 17 commits August 31, 2026 14:37

wip

0f008d6

fix migration and fixtures

a94eb53

fix remaning tests and migrations

a3e26eb

add array inclusion validation and trads

3f8d62f

small twicks

22f29c8

make decorators use new enum array

f852179

fix test

e047364

use function instead of var for clarity

b7ab956

apply review changes wip

2b7bbbb

wip

d0534fc

add enum array concern

88d2091

fix concern and tests

81a0006

add usable_by to port_type show

1f98ad4

add port type decorator

ef7a8ca

apply review changes

01dab3c

fix brakeman errors

2343b6e

correct power distribution unit socket decorator

ae4ac74

moxyom force-pushed the 368436-port-type-evolution branch from ea77ce9 to ae4ac74 Compare August 31, 2026 12:38

		scope :attachable_to_server, -> { where("? = ANY(attachable_to)", :server) }
		scope :attachable_to_pdu, -> { where("? = ANY(attachable_to)", :pdu) }

	scope :attachable_to_server, -> { where("? = ANY(attachable_to)", :server) }
	scope :attachable_to_pdu, -> { where("? = ANY(attachable_to)", :pdu) }
	scope :usable_by, -> (usable_by) { where("? = ANY(attachable_to)", usable_by) }

	create_enum :port_attachable_type, %w[pdu server]
	create_enum :port_types_usable_by, %w[pdu server]

	port_type.update!(is_power: port_type.name == "ALIM", attachable_to: ["server"])
	port_type.update!(is_power: port_type.name == "ALIM", usable_by: ["server"])

	add_column :port_types, :attachable_to, :enum, enum_type: :port_attachable_type, array: true
	add_column :port_types, :usable_by, :enum, enum_type: :port_types_usable_by, array: true

	array_inclusion: "includes unauthorized values : %{wrong_values}"
	array_inclusion: "includes unauthorized values: %{wrong_values}"

Conversation

moxyom commented Jul 28, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants