Manage not found on connection edit - #812
Open
moxyom wants to merge 5 commits into
Open
Conversation
B-Rass
requested changes
Sep 3, 2026
| params[:connection][:vlans], | ||
| params[:connection][:special_case], | ||
| params[:connection][:comments]) | ||
| if params[:connection][:to_port_id].presence |
Collaborator
There was a problem hiding this comment.
if params[:connection][:to_port_id].present?or
if to_port_id = params[:connection][:to_port_id].presence| @to_server = to_port.server | ||
| else | ||
| # destroy connections if to_port_id set to null | ||
| from_port.connections.each do |connection| |
Collaborator
There was a problem hiding this comment.
Why destroying connection? Did you notice case where it was needed?
I don't say it's not a good idea, just I want to know what makes you add this
| connection.destroy | ||
| end | ||
|
|
||
| from_port.update(vlans: "", color: "", cablename: "") |
Collaborator
There was a problem hiding this comment.
Better update with values from form. With this solution I can't, for example, add a Vlan to a port without connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.