fix: call initGroupFilesystem after ncl groups create#2610
Open
jrnanocore wants to merge 1 commit into
Open
Conversation
`ncl groups create` inserted the `agent_groups` row but never called `initGroupFilesystem`, so no `container_configs` row was created and the container failed to spawn with "Container config not found". Add an optional `afterCreate` hook to `ResourceDef` so resources can run post-insert side-effects without duplicating the generic create logic. Wire it in the groups resource to call `initGroupFilesystem`, which creates the `container_configs` row and sets up the group filesystem. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ncl groups createinserts theagent_groupsrow but never callsinitGroupFilesystem, so nocontainer_configsrow is created. When the host later tries to spawn a container for the new group, it fails with:The host-sweep keeps retrying every 60 seconds but the container never starts.
Fix
Add an optional
afterCreatehook toResourceDefincrud.ts. Resources can use it to run post-insert side-effects without duplicating the generic create logic.Wire it in the groups resource to call
initGroupFilesystem, which:groups/<folder>/CLAUDE.local.mdcontainer_configsrow viaensureContainerConfig.claude-shared/directory andsettings.jsonTesting
ncl groups create --name test --folder test🤖 Generated with Claude Code