Skip to content

Disable LMDB read ahead on Windows #4961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RickiNano wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Disable LMDB read ahead on Windows #4961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions nano/store/lmdb/lmdb_env.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,12 @@ void nano::store::lmdb::env::init (std::filesystem::path const & path_a, nano::s

// It seems if there's ever more threads than mdb_env_set_maxreaders has read slots available, we get failures on transaction creation unless MDB_NOTLS is specified
// This can happen if something like 256 io_threads are specified in the node config
// MDB_NORDAHEAD will allow platforms that support it to load the DB in memory as needed.
// MDB_NORDAHEAD will allow platforms that support it to load the DB in memory as needed, but is disabled on Windows to prevent excessive memory usage.
// MDB_NOMEMINIT prevents zeroing malloc'ed pages. Can provide improvement for non-sensitive data but may make memory checkers noisy (e.g valgrind).
auto environment_flags = MDB_NOSUBDIR | MDB_NOTLS | MDB_NORDAHEAD;
auto environment_flags = MDB_NOSUBDIR | MDB_NOTLS;
#ifndef _WIN32
environment_flags |= MDB_NORDAHEAD;
#endif
if (options_a.config.sync == nano::lmdb_config::sync_strategy::nosync_safe)
{
environment_flags |= MDB_NOMETASYNC;
Expand Down
Loading