fix(metrics): self-prefix instruments with the service namespace#9
Merged
Conversation
The dashboard + PrometheusRule query competitive_intelligence_* series, but the instruments were named unprefixed (crawl.sources, …) on the assumption that a collector-side service-name namespace would add the prefix. The grafana-agent OTLP→Prometheus bridge does not do that — so the series would land as crawl_sources_total and the board would read hollow. Prefix every instrument with the NAMESPACE in this module: crawl.sources is now created as competitive_intelligence.crawl.sources, which OTLP→Prometheus renders as competitive_intelligence_crawl_sources_total deterministically, with no dependency on collector config. Call sites and the dashboard are unchanged.
stxkxs
force-pushed
the
self-prefix-metrics
branch
from
fcc0e37 to
cddb91b
Compare
stxkxs
added a commit
that referenced
this pull request
Jun 24, 2026
Format-only follow-up to #9 (the self-prefix edit failed format:check). prettier --write applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard queries
competitive_intelligence_*, but the instruments were named unprefixed (crawl.sources) assuming a collector-side namespace would add the prefix — which the grafana-agent OTLP→Prometheus bridge doesn't do, so the series would land ascrawl_sources_totaland the board would render hollow. Prefixes every instrument inmetrics.tswith thecompetitive_intelligencenamespace so the Prometheus names are deterministic (no collector magic). Call sites + dashboard unchanged; typecheck + tests pass.