fix(dashboards): de-hollow the last two persona panels missed by the KSM rewrite#57
Merged
Conversation
…KSM rewrite An observability audit found two panels still querying metrics that produce nothing in prod — the same hollowness the agent-* rewrite was meant to eliminate. agent-founder "Top initiatives" — queried agents_agent_invocations_total, a counter no operator/portal/agentgateway code ever registers, grouped by platform_id, a label no series carries. Repointed to a real, populated series that fits the exec board's spend theme: top-10 Tenants by aggregate spend over the kube-state-metrics customResourceState projection (Tenant.status.aggregateSpendUsd) — the same metric family the board's other spend panels already use. agent-tenants "Platform ready ratio" — queried the recording rule agents:platforms:ready_ratio, which only the operator's PrometheusRule defines. Prod has no ruler (no prometheus-operator, no AMP ruler), so the series never exists. Replaced with the inline form already used on agent-operator: count of Platform CRs in Ready phase over the total, both from kube_customresource_status_phase. Both boards now render entirely over series that reach AMP.
CI Results
All validations passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An o11y audit found two panels still over metrics that emit nothing in prod:
agents_agent_invocations_total— a counter nothing in the org registers, grouped byplatform_id(a label no series carries). Repointed to top-10 Tenants bykube_customresource_status_fieldaggregate spend (the metric family the board's other panels already use), fitting the exec/spend theme and populated now.agents:platforms:ready_ratio, defined only in the operator's PrometheusRule — inert in prod (no ruler). Replaced with the inlinekube_customresource_status_phaseform already used on the agent-operator board.Both boards now render entirely over series that reach AMP. Embedded JSON parses, yamllint + all dashboard overlays build.