Rename almanac to slack-knowledge-bot + retrofit chart onto tenant-chart-base#5
Merged
Merged
Conversation
…art-base
Full codename shed for the Slack knowledge bot tenant and a chart retrofit
onto the shared library chart. Never deployed, so this is a clean rename.
─── Codename rename ───
- Identity renamed everywhere: npm package + the slack-knowledge-bot-oauth
sub-package, OTel service.name / agents.platform, the /slack-knowledge-bot
slash command, class + factory names (SlackKnowledgeBotOAuth,
createSlackKnowledgeBotOAuth), Platform CR, ApplicationSet entry, image
repo, docs.
- Metrics: METER_NAME is the kebab service name (slack-knowledge-bot); the
collector snake-cases the scope into the Prometheus prefix, so the
PrometheusRule + dashboard PromQL use slack_knowledge_bot_* and the alert
names use the PascalCase form (SlackKnowledgeBot…). Dashboard file renamed
to chart/dashboards/slack-knowledge-bot.json.
- Substrate references realigned to the renamed landing-zone
slack-knowledge-bot-platform component: DynamoDB table names now follow
the component's ${prefix}-<resource> convention
(slack-knowledge-bot-<env>-{tokens,audit,identity-cache}), Secrets Manager
paths (slack-knowledge-bot/<env>/*), and the RDS DB name uses the snake
form (slack_knowledge_bot) since it's a SQL identifier.
─── Chart retrofit (chart/charts/tenant-chart-base) ───
- Vendored the tenant-chart-base library and added it as a file://
dependency. serviceaccount / networkpolicy / grafana-dashboard are now
one-line includes of the library's named templates; the deployments,
service, ingress, externalsecret, prometheusrule, and scaledobject use the
library's name/label/selector/serviceAccountName helpers. Dropped the
per-chart _helpers.tpl.
- Added otel.resourceAttributes (agents.tenant/agents.platform) so the
library labels resolve. The audit-consumer keeps its own
slack-knowledge-bot.io/service selector label.
Build, typecheck, lint, prettier, and 126 tests pass; helm lint + template
(base + per-env) render and the rendered substrate references match the
landing-zone component outputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full codename shed for the Slack knowledge bot tenant plus a Helm chart retrofit onto the shared
tenant-chart-baselibrary. Never deployed — clean greenfield rename.Codename rename
slack-knowledge-bot-oauthsub-package, OTelservice.name/agents.platform, the/slack-knowledge-botslash command, class + factory names (SlackKnowledgeBotOAuth,createSlackKnowledgeBotOAuth), Platform CR, ApplicationSet entry, image repo, docs.METER_NAMEis the kebab service name; the OTLP→Prometheus collector snake-cases the scope into the metric prefix, so the PrometheusRule + dashboard PromQL useslack_knowledge_bot_*and alert names use the PascalCase form. Dashboard renamed tochart/dashboards/slack-knowledge-bot.json.slack-knowledge-bot-platformcomponent: DynamoDB tables follow the component's${prefix}-<resource>convention (slack-knowledge-bot-<env>-{tokens,audit,identity-cache}), Secrets Manager paths (slack-knowledge-bot/<env>/*), and the RDS DB name uses the snake form (slack_knowledge_bot).Chart retrofit (
chart/charts/tenant-chart-base)file://dependency.serviceaccount/networkpolicy/grafana-dashboardare one-line includes of the library's named templates; deployments, service, ingress, externalsecret, prometheusrule, scaledobject use the library helpers. Dropped the per-chart_helpers.tpl.otel.resourceAttributesso the library labels resolve. The audit-consumer keeps its ownslack-knowledge-bot.io/serviceselector label.Paired with
nanohype/landing-zone#41(the substrate rename). Build, typecheck, lint, prettier, and 126 tests pass;helm lint+helm template(base + per-env) render and the rendered substrate references match the landing-zone component outputs.