Prestonr switched on check - #164
Merged
Merged
Conversation
JosephBowkett
left a comment
JosephBowkett
left a comment
Collaborator
There was a problem hiding this comment.
Consolidate the error printing and add more messages so we can see what the transitions were
Collaborator
|
Looks good to me! Just tested on the single elmo testbed |
Collaborator
|
Once it's merged I'll add the utils |
Collaborator
|
@preston-rogers the automated build seems to be failing though? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modification to MR 161.
Previously, the actuator would error out immediately when SWITCHED_ON was experienced.
The true issue is the transition from OPERATION_ENABLED to SWITCHED_ON which requires time for the typical initialization process to get to OPERATION_ENABLED first before SWITCHED_ON is truly an error scenario.