Merge msgs - #10
Merged
Merged
Merge msgs#10
Conversation
…, changed package name to fcat_msgs_ros2 in package.xml, changed file path to messages in CMakeLists.txt, and changed actual_current data type in EgdState.msg.
…e to 'msg' from 'msgs' to avoid confusion.
…3208 devices. Also adjusted the CommanderState message type to match new behavior.
…rtualFtsState messages. Also changed contents of EgdProfPosCmd message.
…use arrays, because that doesn't seem to work.
…. The latter controls which state messages get published by fcat_wrapper. Also added current state of each state message setting to ModuleState.
… an ack response.
…V since fastcat v0.2.0
…signer recommendations
Adding el2828 driver See merge request casah/rosx/fcat_msgs!38
Adding el2828 driver See merge request casah/rosx/fcat_msgs!38
Kwehage el3314 See merge request casah/rosx/fcat_msgs!39
Kwehage el3314 See merge request casah/rosx/fcat_msgs!39
Prestonr add el5042 See merge request casah/rosx/fcat_msgs!41
Prestonr add el5042 See merge request casah/rosx/fcat_msgs!41
Add csv and cst multi message definitions See merge request casah/rosx/fcat_msgs!43
Add csv and cst multi message definitions See merge request casah/rosx/fcat_msgs!43
Main merge2
Cleanup after bring internal
Co-authored-by: Copilot <copilot@github.com>
Collaborator
|
@PastorD put Otherwise it looks good to me! |
JosephBowkett
approved these changes
May 4, 2026
JosephBowkett
left a comment
JosephBowkett
left a comment
Collaborator
There was a problem hiding this comment.
looks good, CI passes, good to know we can CI them side by side now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate fcat and fcat_msgs into a single repository for easier development.
Each package remains its own ros2 package. This structure allows to add more packages related to fcat in the future. Moving back fcat_msgs in the future if it is needed.
Keep history with
git mvfor fcat filesgit subtreefor fcat_msgsAdjust github action workflow now fcat_msgs is inside the repo. Remove local deb package of python3-cogapp
No other changes besides merging msgs
bump:minor
@JosephBowkett @kwehage @preston-rogers @dwai-wai
FAQ: what about if another project only needs fcat or fcat_msgs?
They can ignore the package they don't need by using
--packages-up-totheir package, orCOLCON_IGNOREmarker