Skip to content

Fix save positions - #13

Merged
PastorD merged 6 commits into
mainfrom
fix-save-positions
Sep 1, 2026
Merged

PastorD merged 6 commits into
mainfrom
fix-save-positions

Conversation

@PastorD

@PastorD PastorD commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Part of improving how it saves positions to avoid losing calibration

  • use add_pre_shutdown_callback for more reliable saving at the end.

bump:minor

Bugfix:

  • Initialize to zero fastcat::DeviceCmd cmd{}

Merge with fastcat save-positions, change to tag before merging this

@nasa-jpl/nasa-jpl-ethercat-devs

@PastorD PastorD self-assigned this Aug 11, 2026
@PastorD
PastorD requested a review from a team August 11, 2026 16:47
@PastorD
PastorD requested a review from JosephBowkett August 12, 2026 20:00
@PastorD

PastorD commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author
  • tested with latest fastca in Astrobud, no issues: move joints and move cart works well
  • run a "/review" check with Opus 5 and it showed to issues. Some comments that do not neccessary
  • try/catch around the call_once body — real (a throw during the destructor path means std::terminate) but not a regression; the old Shutdown() call had identical exposure.
  • Calling fcat_manager_.Shutdown() instead of SaveActuatorPositions() — behavior-neutral at v0.13.20, just a coupling risk if upstream moves teardown back into Shutdown().
  • The destructor deregistration + fallback themselves — unreachable today, kept as future-proofing.

@JosephBowkett JosephBowkett left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, other than catching a failed bus during motion, when we would not want to save to the normal position file, but would prefer to record the last known position in case we want to use that to recover.

@PastorD
PastorD merged commit 83bab3e into main Sep 1, 2026
2 checks passed
@PastorD
PastorD deleted the fix-save-positions branch September 1, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants