Skip to content

Found el1008 gave values greater than 1 #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
preston-rogers merged 1 commit into from
Feb 25, 2026
Merged

Found el1008 gave values greater than 1 #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/jsd_el1008.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ void jsd_el1008_read(jsd_t* self, uint16_t slave_id) {
(jsd_el1008_txpdo_t*)self->ecx_context.slavelist[slave_id].inputs;

for (int ch = 0; ch < JSD_EL1008_NUM_CHANNELS; ++ch) {
state->values[ch] = (1 << ch) & txpdo->channels; // Bit shift the channel to get value
state->values[ch] = (bool)((1 << ch) & txpdo->channels); // Bit shift the channel to get value
}
}

Expand Down Expand Up @@ -74,4 +74,4 @@ int jsd_el1008_PO2SO_config(ecx_contextt* ecx_context, uint16_t slave_id) {

bool jsd_el1008_product_code_is_compatible(uint32_t product_code) {
return product_code == JSD_EL1008_PRODUCT_CODE;
}
}
Loading