Update the SCH codebase to a more recent cFS revision (March 2023)#26
Open
stanislaw wants to merge 1 commit intonasa:masterfrom
Open
Update the SCH codebase to a more recent cFS revision (March 2023)#26stanislaw wants to merge 1 commit intonasa:masterfrom
stanislaw wants to merge 1 commit intonasa:masterfrom
Conversation
This changeset contains 98%+ fixes that are needed to have this SCH working against the more recent cFS setup as of March 2023. The cFS revision that this is compiled against: 192f2ea3061bfe722b8ed1d72b7adecbf36d4f6e nasa/cFS@192f2ea Known issues: - The changeset contains minor formatting issues but I am deciding to ignore them because the SCH itself needs to be Clang Formatted and I didn't find an existing .clang-format in the repository. - This changeset does not touch anything related to setting up the table files in the CMake build system. There are other patches that are attempting to fix those issues: https://github.com/nasa/SCH/pull/6/files - We are still reworking the SCH codebase to fit our needs, so it may be that a few lines were missed and they will not compile.
stanislaw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
We learned that the SCH codebase had not been updated since June 2019, so we updated it to have it at least compile with our customized cFS build system.
We hope that this work will help someone like us to get to a working SCH faster.
If there was any interest in integrating this work, we would be happy to resolve any issues with this patch. Before doing any integration, we would highly recommend setting up Clang Format for SCH, using the
.clang-formatfrom the parent cFS repository. With the formatting in place, it would be much easier to work with the needed diffs.This contribution is made on behalf of Reflex Aerospace GmbH (Berlin) where I am employed as a software engineer.
This changeset contains 90%+ fixes that are needed to have this SCH working against the more recent cFS setup as of March 2023.
The cFS revision that this is compiled against: 192f2ea3061bfe722b8ed1d72b7adecbf36d4f6e
nasa/cFS@192f2ea
Known issues: