-
Notifications
You must be signed in to change notification settings - Fork 3
Improve Batchee with Performance Boosts and Error Handling #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Yusufibin, thanks for your interest in this repository and for sharing these proposed code changes! In particular, I believe the following three changes will be improvements to the robustness of the if not input_items:
return []def test_empty_list():
results = get_batch_indices([])
assert results == []def test_invalid_filenames():
invalid_filenames = ["invalid.nc", "TEMPO_NO2_L2_V03_20240731.nc", "random_file.txt"]
results = get_batch_indices(invalid_filenames)
assert results == []I believe the other changes will add unnecessary complexity. If you are able to remove the other changes, we should be able to then merge these three above changes into the develop branch. |
|
Hello @danielfromearth ,
All other changes (URL validation, performance optimizations, output formats, high-volume testing, etc.) have been removed. The tests pass successfully, confirming that the code remains functional. The pull request is now ready for potential merging into the develop branch. |
danielfromearth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yusufibin, this looks good now. Thank you for making the updates!
There's one line here that I think should be reverted to how it was before, but otherwise it will be ready to go (pending new CHANGELOG entry and tests passing).
|
@danielfromearth Done |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Added comment to clarify the purpose of the day_and_scans list.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Main Changes
### Tests
All existing tests pass.
New tests added for edge cases.
Verified backward compatibility.