fix(security): 2 improvements across 2 files#4467
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Potential Command Injection via GraphQL Query Construction - Security: Unsafe JSON Parsing without Validation Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Potential Command Injection via GraphQL Query Construction - Security: Unsafe JSON Parsing without Validation Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Medium| File:bamboo/detect-pr.js:L10In bamboo/detect-pr.js, user-controlled input from process.argv is directly interpolated into a GraphQL query string without sanitization. While this is in a build script context, the headRefName and baseRefName values are embedded directly into the GraphQL template literal, which could lead to injection if malicious branch names are provided.
Solution
Use GraphQL variables instead of string interpolation for dynamic values. Pass headRefName and baseRefName as variables in the request payload rather than embedding them in the query string.
Changes
bamboo/detect-pr.js(modified)packages/api-client/src/cumulusApiClient.ts(modified)