Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 437 438 +1
Lines 7201 7204 +3
Branches 1544 1545 +1
=======================================
+ Hits 7068 7071 +3
Misses 132 132
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cgokey
reviewed
Mar 11, 2026
| "edscHost": "https://search.sit.earthdata.nasa.gov", | ||
| "kmsHost": "https://cmr.sit.earthdata.nasa.gov/kms", | ||
| "kmsHost": "/see-vite-config-proxy", | ||
| "kmKmsClientID": "mmt-keyword-manager-development", |
Collaborator
There was a problem hiding this comment.
maybe keywordManagerClientId for the name?
cgokey
approved these changes
Mar 13, 2026
| "mmtHost": "http://localhost:5173", | ||
| "edscHost": "https://search.sit.earthdata.nasa.gov", | ||
| "kmsHost": "https://cmr.sit.earthdata.nasa.gov/kms", | ||
| "kmsHost": "/see-vite-config-proxy", |
Contributor
There was a problem hiding this comment.
Kind of confused about this. Why do we need the proxy to pass the extra header?
Contributor
Author
There was a problem hiding this comment.
The extra header, somehow, trigger CORS, so the proxy needed for local dev. In other env, 'kmsHost' is overwritten by the bamboo deployment script.
Contributor
Author
There was a problem hiding this comment.
The issue came up as I test client-id on my local MMT pointing to cmr.sit.
eudoroolivares2016
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Add a client-id to all KMS calls
What is the Solution?
Add a client-id in headers to all KMS call
What areas of the application does this impact?
KeywordManager calls to KMS to fetch, update, insert and delete keywords. Also publish a new keyword version.
Testing
Request headers to kms should have as 'client-id' 'mmt-keyword-manager-$env'
Attachments
N/A
Checklist