Add raw terminal mode to spacewasi - #139
Merged
Merged
Conversation
CoreMark Benchmark ResultsCurrent Score: 244.708 |
Code Coverage ReportCurrent Coverage: 95.29% |
Kronos3
approved these changes
Jul 30, 2026
Kronos3
left a comment
Kronos3
left a comment
Contributor
There was a problem hiding this comment.
Looks good, please resolve the new merge conflicts and I'll merge
Collaborator
Author
|
Okay, should be all good now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a "raw terminal mode" to the
spacewasicrate using crossterm, and also ups the default page size for more complex WASM files (such as those made with container2wasm.Note that to my current best understanding, true TTY support is not fully supported in wasi1p, so WASM programs cannot enable "raw mode" themselves through typical syscalls. However, this PR adds a
--raw-ttyflag that lets users enable this mode manually for specific programs. Usage with most typical WASI programs will result in strange screen buffering issues and missing carriage returns, though, so use sparingly.