Fix critical bugs and improve file hashing performance#28
Closed
kreynolds wants to merge 9 commits intonashby:masterfrom
Closed
Fix critical bugs and improve file hashing performance#28kreynolds wants to merge 9 commits intonashby:masterfrom
kreynolds wants to merge 9 commits intonashby:masterfrom
Conversation
Owner
|
Hey! Thanks for the PR but it's better to propose these changes to https://github.com/Cyan4973/xxHash directly since this gem is just a wrapper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have some Claude Max burning a hole in my pocket so I'm running it on some of the gems that I've found useful over the years. The following is a guided use of that for this gem.
Overview
Fixes critical memory leaks and data corruption issues, plus performance improvements for file hashing.
Changes
Critical Fixes:
High Priority Fixes:
XXH3_64bits_reset_withSecret()XXH_alignedMalloc()Performance:
Code Quality:
XXH32_hash_tfor type consistencyTesting
All 21 existing tests pass with no regressions.