Update to xxhash 0.8.3 and ammend Ractor tests#30
Merged
nashby merged 2 commits intonashby:masterfrom Mar 26, 2026
Merged
Conversation
Owner
|
@dysonreturns thanks! I'll add 4.0 to CI. Ruby 2 is not officially supported though so it's fine. I'll consider adding required version config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
This change aims to bring forward some performance updates from xxhash since 0.8.1 particularly on
arm, by updating to the latest release0.8.3.Upgrade path:
I noticed which files libxxhash.c and libxxhash.h correspond to in the official repo and updated them like this:
Feel free to verify they match exactly.
Tests: The Ractor test failed for Ruby 4, which now has slightly different Ractor syntax, so there's now a conditional for Ruby 3 and Ruby 4 in the spec.
Manual tests per Ruby: I built and spot-checked Rubies
3.2.x,3.3.xand4.0.x. They all appear fine.I wasn't able to compile for Ruby 2.x on my MacOS, but that might just be me. I'm not sure whether 2.x is supported, even. Maybe consider marking a min Ruby version in the gemspec if that's the case?
3.2.x is end-of-life shortly, so 3.3 is a good target.