Repository navigation
Add default-on Jev → Luna Pi observer with minimal YSK UI - #849
Merged
Merged
Conversation
Supersedes #842.
Adapt Armin Ronacher’s agent-stuff side-chat design; replace the managed BTW package. Supersedes #842.
Markdown rows bypassed the border and padding helper, leaving the main screen visible through the overlay. Frame every transcript row; lock down real SDK Markdown rendering and full-width coverage. Related #842.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is AI-assisted. Model: gpt-6.1-sol
YSK-BTW-demo.mp4
Summary
Supersedes #842 with the default-on production Jev → Luna observer and the terminal UI refined in the live demo.
/ysk-demo on,/ysk-demo off, or a bare float from 0–1 controls enabled state and gate threshold (default 0.85). Settings restore from the active branch.jev-1.13.0request batches interruption/category decisions per checkpoint. OnlyP(warn) >= thresholdcalls pinned, independent, tool-lessopenai/gpt-6-lunavia Pi’s model registry. Operator confirmed Jev’s Datasafe qualification; incompatible profiles fail closed.YSK:plus the note; quiet/declined results remove the widget entirely.·when idle). Unknown spend displays?, not a fabricated zero.TYPESAFE_API_KEYand existing Luna credentials.test/*_test.mjsgenerically. README.md is unchanged.Independent review and fixes
A fresh-context reviewer found three actionable issues; all were fixed and independently re-reviewed with no remaining blockers:
redirect: error; actual SDK transport regressions verify both providers.Validation
The previous head passed all applicable hosted CI; hosted checks are rerunning for head
d177224ec7c27da082769eb524b499273d63aafe. No merge, installation or machine convergence performed.Approved animated transition
After Jev passes the gate, show bold/accent
YSK:and dimReviewing a possible issuewith dots cycling.,..,...every 400ms while Luna responds. Replace with a static explanation, or clear on decline/error/cancellation/off. Provisional text is never persisted as a warning. Seven regressions cover gate timing, all completion paths and deterministic animation. Actual regular 100-column/fullscreen 48-column PTY proofs verify every dot phase using delayed mocked providers (no network or paid calls). No acknowledgement controls or ignored-check suppression were implemented. Side-chat was subsequently approved and added below.Approved simpler BTW / YSK side-chat
Adapt Armin Ronacher’s Apache-2.0 agent-stuff/extensions/btw.ts design, pinned upstream 0865c849befd2021490679f96a8dee58c84ac857, into a shared local overlay/backend/thread controller. Preserve attribution and the upstream license. Remove npm:@narumitw/pi-btw@0.61.1 from managed settings; do not enable Armin’s original BTW extension too.
/btw [question]uses the main model/context with read/bash/edit/write;--newexplicitly starts fresh./ysk-chat [question]uses only pinned Luna, no tools/fallback/retries/redirects, and the warning’s original bounded text-only snapshot, not evolving main context. Opening the composer makes no model request./ysk-dismisshides without claiming understanding. No commands, buttons or understanding quiz are displayed beside the warning./btw-injector/ysk-injectsends text back to the main agent. No automatic handoff or paid summary generation.Validation: all 85 tests and strict typing pass. Actual SDK CLI fixtures prove model/tool boundaries, original snapshot, multi-process restoration, separate history, no main injection, fresh-thread reset and dismissal. Actual SDK mocked OpenAI SSE transport proves redirect policy and interrupted-usage accounting. Deterministic lifecycle tests cover late answers, close, branch changes, deadlines and recovery. Regular 100-column/fullscreen 48-column PTY proofs pass both composers, zero-request opening, streaming, Esc-close and invisible command hints; all new provider proofs were network-free. Published code/config/test blobs verified against tested local contents; helper remains 100755. No merge, installation or live convergence performed.
Shared-overlay screenshot regression fix
The reported demo screenshot exposed missing side borders and main-screen text bleeding into the chat. Markdown transcript rows bypassed the existing full-width border/padding helper; applying it to every row fixes both BTW and YSK chat. Actual SDK renderer regression covers 15 combinations of width/content, including blank rows, wrapping, Unicode and code blocks. Native PTY composition checks pass for both chats at regular100/fullscreen48. All 86 tests, strict extension typing and whitespace checks pass. Published three blobs verified against tested sources; executable helper mode remains 100755. Demo snapshot refreshed, no live installation. Fix head: 68a076e.