Skip to content

refactor exiftool to use the exiftool -json output method... #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
narcoticfresh wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor exiftool to use the exiftool -json output method... #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac03680
refactor exiftool to use the exiftool -json output method, makes ever…
narcoticfresh Jan 17, 2015
b712b8d
fix field names; make it camelcase again..
narcoticfresh Jan 17, 2015
09717fe
some better error handling; don't wrap call of cb with try/catch..
narcoticfresh Jan 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 32 additions & 33 deletions lib/exiftool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,21 @@ exports.metadata = function (source, tags, doneGettingMetadata) {
}

// The dash specifies to read data from stdin.
var args = (tags === [] ? ['-'] : tags.push("-"));
var exif = ChildProcess.spawn('exiftool', tags);
var args = [];
if (typeof(tags) == 'object' && tags.length > 0) {
args = tags;
}

args.push('-json');
args.push('-');

var exif = ChildProcess.spawn('exiftool', args);

//Check for error because of the child process not being found / launched.
exif.on('error', function (err) {
doneGettingMetadata('Fatal Error: Unable to load exiftool. ' + err);
});

// Read the binary data back
var response = '';
var errorMessage = '';
exif.stdout.on("data", function (data) {
Expand All @@ -31,41 +37,34 @@ exports.metadata = function (source, tags, doneGettingMetadata) {

// Handle the response to the callback to hand the metadata back.
exif.on("close", function () {
if (errorMessage)
{
if (errorMessage) {
doneGettingMetadata(errorMessage);
}
else
{
// Split the response into lines.
response = response.split("\n");
else {
try {
var jsonResponse = JSON.parse(response);
} catch (e) {
doneGettingMetadata('Fatal Error: Unable to parse exiftool output.');
}

//For each line of the response extract the meta data into a nice associative array
var metaData = [];
response.forEach(function (responseLine) {
var pieces = responseLine.split(": ");
//Is this a line with a meta data pair on it?
if (pieces.length == 2)
{
//Turn the plain text data key into a camel case key.
var key = pieces[0].trim().split(' ').map(
function (tokenInKey, tokenNumber) {
if (tokenNumber === 0)
return tokenInKey.toLowerCase();
else
return tokenInKey[0].toUpperCase() + tokenInKey.slice(1);
}
).join('');
//Trim the value associated with the key to make it nice.
var value = pieces[1].trim();
if (!isNaN(value))
{
value = parseFloat(value, 10);
/**
* exiftool outputs a strange thing: an array with 1 object inside..
* convert it to a simple array as that is what this component returned before..
*/
if (typeof(jsonResponse[0]) == 'object') {
var metaData = [];
for (i in jsonResponse[0]) {
// make it camelcase..
if (i.length > 1) {
propName = i.substr(0, 1).toLowerCase() + i.substr(1);
metaData[propName] = jsonResponse[0][i];
}
metaData[key] = value;
}
});
doneGettingMetadata(null, metaData);
doneGettingMetadata(null, metaData);
} else {
doneGettingMetadata('exiftool returned a wrong format. Did you override the format with arguments?');
}

}
});

Expand Down